Document the landing-pad cleanup-marker contract; close out review item 8#235
Merged
Merged
Conversation
…em 8 Item 8 of docs/LowerToAffineLoops-LowerToLLVM-review.md (the self-flagged "BUG: in LLVM landing pad is not fully implemented" in the Windows LandingPadOpLowering) is resolved as not-a-defect after tracing the full cross-pass flow: the suspicious clause is the undef-array marker built in TryOpLowering (never an RTTI pointer), which becomes an LLVM *filter* clause and serves as a deliberate cleanup marker. LandingPadFixPass (always first in the LLVM pipeline, before any optimization) canonicalizes such pads to clause-less cleanup landingpads, and Win32ExceptionPass then replaces all pads with SEH funclets -- verified empirically via final-IR dumps on both Windows and Linux triples (zero filter clauses survive; Windows IR has zero landingpads at all). Rewrites the misleading BUG/HACK comments at all three sites (marker construction, filter emission, filter detection) into accurate contract documentation cross-referencing each other, and renames the catch1Fake local to cleanupMarker. No functional change; full ctest suite green (690/690, JIT + AOT). With this, all 10 findings from the lowering-passes review are closed (9 fixed, 1 resolved as not-a-bug). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
3 tasks
ASDAlexander77
added a commit
that referenced
this pull request
Jul 15, 2026
A follow-up static audit of LowerToAffineLoops.cpp, LowerToLLVM.cpp, and the TypeScriptExceptionPass files (beyond the 10 findings already closed in PRs #230/#232/#233/#234/#235) found and fixes 7 more confirmed bugs: - SwitchStateOpLowering: generator yield/resume state labels were collected into a SmallPtrSet<Operation*,16>, whose iteration order is only insertion order below 16 entries; past that it silently falls back to pointer-hash order, scrambling the positional switch dispatch used by generator resume. Replaced with an order-preserving SmallVector. - StringConcatOpLowering: the stack-allocation path sized its Alloca using a pointer type instead of i8, over-allocating by sizeof(ptr) for every multi-argument string concatenation (e.g. console.log with 2+ args). - ArraySpliceOpLowering: mixed genuine MLIR index-dialect ops with already-LLVM-converted operands, a type mismatch that made every Array.prototype.splice() call fail to lower correctly (the only .splice() call in the test suite was commented out because of this). Reworked to stay consistently in the LLVM-converted domain, matching every sibling array-mutation lowering. - GlobalOpLowering: the side-effect enumeration deciding whether a global initializer can be inlined as a constant vs. must run as a real constructor was missing several ops with real side effects (array push/unshift/splice/pop/shift, delete, set-length, string concat/ char-to-string). - LandingPadFixPass: MadeChange was set unconditionally for every landingpad visited, even when nothing was rewritten, causing needless analysis invalidation on every EH-containing function on every compile. - Win32ExceptionPass: the PHI-user removal loop erased only the first PHI user found then unconditionally erased the underlying value, violating LLVM's no-remaining-uses invariant when more than one PHI referenced the same to-be-removed value (own TODO comment flagged this as incomplete). - Win32ExceptionPass: getThrowFn's fallback path created a stray _CxxThrowException Function without attaching it to the module. Added 00array_splice.ts (JIT + AOT) covering shrink/grow/equal-size splice cases, since this path had zero prior test coverage. Full ctest suite green: 692/692. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the last open finding (item 8) of
docs/LowerToAffineLoops-LowerToLLVM-review.md— resolved as not a defect after tracing the full cross-pass flow, rather than "fixed":windows::LandingPadOpLowering's cleanup branch is not a typed-catch RTTI value (the original review misread it) — for cleanup pads it is always the undef-array marker built inTryOpLowering. Being array-typed, it becomes an LLVM filter clause: a deliberate cleanup marker consumed by the custom LLVM passes.LandingPadFixPassruns unconditionally first in the LLVM pipeline (transform.cpp:323, before any optimization) and canonicalizes every filter-bearing landingpad to a clause-lesslandingpad { cleanup };Win32ExceptionPass(Windows, second) then converts pads to SEH funclets and erases every landingpad. The optimizer/inliner runs only after both — the filter never reaches EH-table emission on either platform.--emit=llvmfinal-IR dumps of00try_finally.ts: Windows triple → zerolandingpad/filterinstructions (all funclets: 24 catchpad / 12 cleanuppad / 13 catchswitch); Linux triple → zerofilter, canonical clause-less cleanup pads, propercatch ptr @_ZTI...catch clauses.Changes: rewrites the misleading self-flagged
BUG/HACKcomments at all three sites (marker construction inLowerToAffineLoops.cpp, filter emission inwindows::LandingPadOpLowering, filter detection inWin32ExceptionPass::isCleanup()) into accurate contract documentation cross-referencing each other; renames thecatch1Fakelocal tocleanupMarker; updates the review doc. No functional change.With this, all 10 findings from the lowering-passes review are closed (9 fixed across #230/#232/#233/#234, 1 resolved as not-a-bug).
Test plan
ctest --test-dir __build/tslang/windows-msbuild-2026-debug -C Debug -j8— 690/690 passed (JIT + AOT)x86_64-pc-windows-msvcandx86_64-pc-linux-gnutriples confirming the marker is fully consumed before codegen